Skip to content

gunicorn 23.0.0, draft#14921

Draft
pajod wants to merge 4 commits intopython:mainfrom
pajod:patch-gunicorn
Draft

gunicorn 23.0.0, draft#14921
pajod wants to merge 4 commits intopython:mainfrom
pajod:patch-gunicorn

Conversation

@pajod
Copy link
Copy Markdown
Contributor

@pajod pajod commented Oct 25, 2025

for @eugeneliukindev

questions:

notes on things I would like to modify:

  • match stdlib wsgiref in that start_response accepts optional exc_info
  • FileWrapper.__getitem__ is odd, mark the argument Never
  • restrict load_class to only classes it is used for via gunicorn.conf.py
  • clarify that write_error shall not inject arbitrary str data
  • most timeout are actually float not int, and gunicorn/workers/sync.py actually uses this
  • timeout_ctx must return a context wrapper
  • overriding ThreadWorker.poller is legitimate
  • handle_request(listener_name) can be either (addr,port) tuples or string (e.g. UNIX sockets)

@github-actions

This comment has been minimized.

@github-actions
Copy link
Copy Markdown
Contributor

According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉

@eugeneliukindev
Copy link
Copy Markdown
Contributor

@pajod Thank you for finding the inconsistencies and correcting them. I did make a mistake while doing PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants